Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Timezone from attendance entries #161

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Use Timezone from attendance entries #161

wants to merge 3 commits into from

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Jan 4, 2023

Summary

This PR is an attempt to implement #158 , where the attendances get a new column/field, where the timezone can be explicitly recorded.

  • Explicit recording for each attendance is only needed when a VSHNeer is changisch zones in the middle of the month.
  • If a VSHNeer is recording attendance in one zone only per month, the timezone can be specified once in the pay slip.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update the documentation.
  • Update/fix tests.
  • Link this PR to related issues.

@ccremer ccremer added the enhancement New feature or request label Jan 4, 2023
@ccremer ccremer temporarily deployed to preview January 4, 2023 10:47 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

🚀 Preview deployment active
App URL https://odootools-pr-161-vshn-odoo-test.apps.cloudscale-lpg-2.appuio.cloud
Revision b485af2
Helm release vshn-odoo-test/odootools-pr-161
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

@ccremer
Copy link
Contributor Author

ccremer commented Jan 4, 2023 •
edited
Loading

Currently, the report as of this WIP looks like following:
image

As can be seen, the days from 20.7. are somewhat off. e.g. Monday 25.7. is missing, resp. is a Sunday in Vancouver yet the Tuesday is still regarded in Zurich tz...

Also, it needs to be verified if the hours recorded are actually associated to the correct day.

@ccremer ccremer linked an issue Jan 4, 2023 that may be closed by this pull request
Consider alternative recording of timezone #158
Open
@ccremer ccremer force-pushed the timezone-attendance branch from b485af2 to 7ce6f22 Compare January 16, 2023 14:03
@github-actions
Copy link

🚀 Preview deployment active
App URL https://odootools-pr-161-vshn-odoo-test.apps.cloudscale-lpg-2.appuio.cloud
Revision 7ce6f22
Helm release vshn-odoo-test/odootools-pr-161
Cluster https://api.cloudscale-lpg-2.appuio.cloud:6443

To uninstall this deployment, close or merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider alternative recording of timezone
1 participant
@ccremer